Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement scaling based on runner demand #2

Closed
davidkarlsen opened this issue Apr 19, 2020 · 5 comments
Closed

implement scaling based on runner demand #2

davidkarlsen opened this issue Apr 19, 2020 · 5 comments
Labels
blocked Blocked by other issue enhancement New feature or request
Milestone
v1

Comments

@davidkarlsen
Copy link
Collaborator

If GH apis will expose if runner is queued with a job or idle (as it is in the UI), scaling can properly implemented to satisfy demand within limits defined in the CR.
@davidkarlsen davidkarlsen added the enhancement New feature or request label Apr 19, 2020
@davidkarlsen davidkarlsen added this to the v1 milestone Apr 20, 2020
@davidkarlsen
Copy link
Collaborator Author

Blocking issue: actions/runner#454

@davidkarlsen davidkarlsen added the blocked Blocked by other issue label Apr 25, 2020
@iagomelanias
Copy link

Hello! 👋
Thank you for creating this operator. It's going to help a lot!

I have a question: what's the current behavior?
Is there any scaling at all or should we set minReplicas and maxReplicas to the same value?

@davidkarlsen
Copy link
Collaborator Author

No scaling for the time being as the API needs to be updated as in the linked issue. If you set min==max it will create that number of runners.

@davidkarlsen
Copy link
Collaborator Author

Related: google/go-github#1589

@davidkarlsen
Copy link
Collaborator Author

@iagomelanias Latest v0.3.0 now supports autoscaling! Please give it a spin.

@davidkarlsen davidkarlsen mentioned this issue Aug 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked Blocked by other issue enhancement New feature or request
Projects
None yet
Milestone
v1
Development

No branches or pull requests
2 participants
@davidkarlsen @iagomelanias