Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of 'compile' property is unclear #20

Closed
dchambers opened this issue Mar 29, 2014 · 6 comments
Closed

Use of 'compile' property is unclear #20

dchambers opened this issue Mar 29, 2014 · 6 comments
Labels

Comments

@dchambers
Copy link

According to the documentation, the 'compile' property can be used to configure the path to the 'retrolambda.jar' that will be used, but it's unclear what this actually means. I'd like to test a fix in retrolambda 1.1.4 (which fixes issue luontola/retrolambda#13), but I ran into these issues:

  1. Maven central doesn't have either retrolambda 1.1.3 or retrolambda 1.1.4.
  2. Setting the property to compile "net.orfjackal.retrolambda:retrolambda:1.1.1" (which is available in maven), didn't actually cause that version to be used.
  3. Compiling retrolambda myself and setting the property to the absolute path of the 'retrolambda.jar' I'd built also had no effect, as retrolambda 1.1.2 was still used.

I assume this issue can probably be fixed by having some more explicit examples in the documentation, though I'm not sure who's responsible for deploying the retrolambda artifact to Maven Central?

@luontola
Copy link

Regarding point 1., they are in Maven Central: http://central.maven.org/maven2/net/orfjackal/retrolambda/retrolambda/

(Version 1.1.4 might not have been there when you first tried it, because there is a couple of hour delay for artifacts to show up in Central, but 1.1.3 has been there for some days already.)

@dchambers
Copy link
Author

Ah, that much is my fault. I just always end up Googling through to this site when I'm searching for a dependency:

and I hadn't realized it was such a stale view of the world.

@luontola
Copy link

It's quite surprising how stale that site is - I didn't know it either. I search artifacts normally using http://search.maven.org/ and it's updated quite quickly.

@evant
Copy link
Owner

evant commented Mar 29, 2014

The compile property is supposed to work exactly like any dependency, i.e. you should be able to give it 'net.orfjackal.retrolambda:retrolambda:1.1.4' to fetch from maven central or files('path/to/retrolambda.jar') to pull it in locally. However, I can confirm that it is actually ignored and only the hardcoded path is used.

As a workaround, you can use the retrolambda configuration directly by

dependencies {
    retrolambdaConfig 'net.orfjackal.retrolambda:retrolambda:1.1.4'
}

I'm considering just making this the default way of setting it, and taking out the compile property completely.

@evant evant added the bug label Mar 29, 2014
@luontola
Copy link

Thanks. That workaround worked.

@evant evant closed this as completed Mar 29, 2014
@dchambers
Copy link
Author

Yes, that worked for me too. Our build is now passing on my machine, which is really excellent news!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants