From b9b557fce5c6ce4ff0d7181452650a8b99edbb91 Mon Sep 17 00:00:00 2001 From: Adrian Galvan Date: Fri, 24 Mar 2023 10:28:02 -0700 Subject: [PATCH 1/3] Removing payment_types connector param --- data/saas/config/stripe_config.yml | 6 +----- tests/ops/integration_tests/saas/test_stripe_task.py | 4 +--- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/data/saas/config/stripe_config.yml b/data/saas/config/stripe_config.yml index d7617ae0813..6c2aa9d0e6f 100644 --- a/data/saas/config/stripe_config.yml +++ b/data/saas/config/stripe_config.yml @@ -9,7 +9,6 @@ saas_config: - name: domain default_value: api.stripe.com - name: api_key - - name: payment_types client_config: protocol: https @@ -141,8 +140,6 @@ saas_config: method: GET path: /v1/customers//payment_methods query_params: - - name: type - value: - name: limit value: 100 param_values: @@ -151,8 +148,6 @@ saas_config: - dataset: field: customer.id direction: from - - name: type - connector_param: payment_types data_path: data pagination: strategy: cursor @@ -161,6 +156,7 @@ saas_config: field: id update: method: POST + ignore_errors: true # payment methods of type us_bank_account cannot be updated at this time. path: /v1/payment_methods/ headers: - name: Content-Type diff --git a/tests/ops/integration_tests/saas/test_stripe_task.py b/tests/ops/integration_tests/saas/test_stripe_task.py index 8a9cc5aadba..587dbd21ab9 100644 --- a/tests/ops/integration_tests/saas/test_stripe_task.py +++ b/tests/ops/integration_tests/saas/test_stripe_task.py @@ -394,7 +394,6 @@ async def test_stripe_access_request_task_with_email( min_size=2, keys=[ "billing_details", - "card", "created", "customer", "id", @@ -1080,7 +1079,6 @@ async def test_stripe_erasure_request_task( min_size=2, keys=[ "billing_details", - "card", "created", "customer", "id", @@ -1172,7 +1170,7 @@ async def test_stripe_erasure_request_task( f"{dataset_name}:card": 1, f"{dataset_name}:customer_balance_transaction": 0, f"{dataset_name}:payment_intent": 0, - f"{dataset_name}:payment_method": 2, + f"{dataset_name}:payment_method": 3, f"{dataset_name}:credit_note": 0, f"{dataset_name}:bank_account": 1, f"{dataset_name}:subscription": 1, From baef63e5cc0e7f178733d5348bc3a1855fefbad8 Mon Sep 17 00:00:00 2001 From: Adrian Galvan Date: Fri, 24 Mar 2023 10:33:34 -0700 Subject: [PATCH 2/3] Updating changelog --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 675db38b34a..bc4d5469ecb 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -32,7 +32,7 @@ The types of changes are: * Changed About Fides page to say "Fides Core Version:" over "Version". [#2899](https://github.com/ethyca/fides/pull/2899) * Polish Admin UI header & navigation [#2897](https://github.com/ethyca/fides/pull/2897) * Give new users a "viewer" role by default [#2900](https://github.com/ethyca/fides/pull/2900) - +* Removing payment types from Stripe connector params [#2915](https://github.com/ethyca/fides/pull/2915) ### Fixed From 99845b510d5a6dff6f0310a33d6776987f98c1b8 Mon Sep 17 00:00:00 2001 From: Adrian Galvan Date: Mon, 27 Mar 2023 08:39:42 -0700 Subject: [PATCH 3/3] Updating version number --- data/saas/config/stripe_config.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/data/saas/config/stripe_config.yml b/data/saas/config/stripe_config.yml index 6c2aa9d0e6f..5a57e2c068a 100644 --- a/data/saas/config/stripe_config.yml +++ b/data/saas/config/stripe_config.yml @@ -3,7 +3,7 @@ saas_config: name: Stripe type: stripe description: A sample schema representing the Stripe connector for Fides - version: 0.0.2 + version: 0.0.3 connector_params: - name: domain