Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Duplicate Dataset Name Column from Data Map #793

Closed
SteveDMurphy opened this issue Jun 21, 2022 · 1 comment
Closed

Remove Duplicate Dataset Name Column from Data Map #793

SteveDMurphy opened this issue Jun 21, 2022 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@SteveDMurphy
Copy link
Contributor

SteveDMurphy commented Jun 21, 2022

Bug Description

The data map currently contains two columns for the data map name (once for the fides dataset name near the front and again for the actual data map). This currently feels unnecessary

Steps to Reproduce

  1. fidesctl apply demo_resources/
  2. fidesctl export datamap
  3. See the duplicate dataset name in columns A and U

Expected behavior

Either get rid of one of the columns of data, or conversely, look at being more specific with the source of the personal data (collection possibly?)

Screenshots

n/a

Environment

  • Version: 1.6.1
  • OS: Darwin
  • Python Version: 3.9
  • Docker Version: 20.10.14

Additional context

This was known earlier but highlighted when updating the columns to be programmatically named with a duplicate key error from Pylint in #779

@SteveDMurphy SteveDMurphy added the bug Something isn't working label Jun 21, 2022
@SteveDMurphy SteveDMurphy changed the title Remove Duplicate Dataset Name from Data Map Remove Duplicate Dataset Name Column from Data Map Jun 21, 2022
@SteveDMurphy SteveDMurphy self-assigned this Jun 21, 2022
@SteveDMurphy
Copy link
Contributor Author

@mfbrown this stems from the original datamap template that was prescribed for us, but seems to make sense to review as part of the UI changes and would love your thoughts/input - thanks!

@NevilleS NevilleS closed this as not planned Won't fix, can't repro, duplicate, stale Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants