Refactor the AWS scanner to scan for _all_ resource types, instead of specific ones

[ThomasLaPiana]

Is your feature request related to a specific problem?

Currently, the AWS scanner can only return a narrow set of resource types

Describe the solution you'd like

The AWS scanner should reply resources of all types

Describe alternatives you've considered, if any

A description of any alternative solutions or features you've considered.

Additional context

There seems to be an additional API that enables this (https://stackoverflow.com/questions/44391817/is-there-a-way-to-list-all-resources-in-aws)

We need:

• name
• arn
• resource type
• zone

[ThomasLaPiana]

@earmenda can you note here what is possible to get when scanning an entire AWS account?

[earmenda]

@ThomasLaPiana

I was able to find a full list of resource types which are supported by the resource tagging api here - https://docs.aws.amazon.com/resourcegroupstagging/latest/APIReference/supported-services.html

I also did some testing and was able to see what that looks like using this command:

aws resourcegroupstaggingapi get-resources | jq -r '.ResourceTagMappingList[].ResourceARN'

This returned 450 arns for our account with id 658462651023. This includes all sorts of things which I added to a page internally - https://ethyca.atlassian.net/wiki/spaces/EN/pages/2343862301/AWS+Resource+Tagging+Api

There is some downsides to this approach:

• Some resource wont be available through this api but I will need guidance on which resources we are interested in
• In the current code some resources rely on metadata to decide if a resource should be created. There is no way to do this through this api. An example of this is RDS, where we only create a system for an RDS database if it is not part of an RDS Cluster.
• We will need some additional metadata for future use cases so it's not clear to me how useful this api is.

[ThomasLaPiana]

Interesting, 450 seems like a lot!

If we think about the foundational reason for this feature's existence, its to help people find systems within their AWS infrastructure. Maybe a good route to go here is to list all of the AWS resources that could potentially be a system and go from there? That way we can decide if the path of least resistance is using this API or updating our current solution to handle all of those resource types