Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to turn TCF on/off #3788

Closed
Kelsey-Ethyca opened this issue Jul 15, 2023 · 4 comments · Fixed by #4220
Closed

Add ability to turn TCF on/off #3788

Kelsey-Ethyca opened this issue Jul 15, 2023 · 4 comments · Fixed by #4220
Assignees

Comments

@Kelsey-Ethyca
Copy link
Contributor

Kelsey-Ethyca commented Jul 15, 2023

This can be a beta feature flag for the frontend.
We will need to figure out how we want this to call the TCF POC api that enables/disables the feature in the backend.

@allisonking
Copy link
Contributor

Is the goal for this ticket to add a toggle to this page for TCF?

Image

I'd hesitate against adding it here as all of the features here are UI features—if one user toggles it, they only change the experience for themselves. However, TCF being enabled is a backend state, so if a user clicks the toggle, it'll make the change for everyone, which might be unexpected. We talked about this a bit when we worked on RBAC, and had punted giving a permission to feature flags since we decided it was okay for most users to see the page since it only makes the change for themselves.

At the very least, maybe it could be a toggle that is on the same page but in a different section which indicates it will affect the backend? Or we should add stricter permissions?

@allisonking
Copy link
Contributor

from @Kelsey-Ethyca : we are not going to do this right now

@TheAndrewJackson
Copy link
Contributor

This is now going to be done using an environment variable and the consent settings related code is going to be removed #4220

@Roger-Ethyca
Copy link
Contributor

moving to done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants