Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Masking Strategies Failing on Null/Non Strings #2391

Closed
pattisdr opened this issue Jan 26, 2023 · 1 comment · Fixed by #2377
Closed

Masking Strategies Failing on Null/Non Strings #2391

pattisdr opened this issue Jan 26, 2023 · 1 comment · Fixed by #2377
Assignees
Labels
bug Something isn't working

Comments

@pattisdr
Copy link
Contributor

Bug Description

Hmac, hash, and likely other masking strategies are failing when a null value is passed in in a list, as well as when a non-string value is passed in.

Steps to Reproduce

  1. Do this...
  2. Then This...

Expected behavior

Null values should be returned as null.
For non-string, I think it makes sense to turn into a string.

Screenshots

If applicable, add screenshots to help explain your problem.

Environment

  • Version:
  • OS:
  • Python Version:
  • Docker Version:

Additional context

Add any other context about the problem here.

@pattisdr pattisdr added the bug Something isn't working label Jan 26, 2023
@pattisdr pattisdr self-assigned this Jan 26, 2023
@seanpreston
Copy link
Contributor

Nice catch @pattisdr thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants