Skip to content
This repository has been archived by the owner on Oct 28, 2021. It is now read-only.

Implement EXTCODEHASH in LegacyVM #5134

Merged
merged 5 commits into from
Jul 31, 2018
Merged

Implement EXTCODEHASH in LegacyVM #5134

merged 5 commits into from
Jul 31, 2018

Conversation

gumb0
Copy link
Member

@gumb0 gumb0 commented Jul 26, 2018

@gumb0 gumb0 added this to the Constantinople milestone Jul 26, 2018
@gumb0 gumb0 force-pushed the extcodehash-legacyvm branch 3 times, most recently from 424f181 to 498802e Compare July 26, 2018 17:05
@axic
Copy link
Member

axic commented Jul 30, 2018

Is it possible to introduce it in both LegacyVM and aleth-interpreter in the same PRs? Or is aleth-interpreter ignored for the non-final-constantinople ones yet? Lastly, would finishing the tracing PR supersede this question? 😉

@gumb0
Copy link
Member Author

gumb0 commented Jul 30, 2018

@axic I can try to include aleth-interpreter support here, though I would prefer them to be separate PRs for more manageable PR size, easier review and to merge this earlier.

I'm not sure what it has to do with tracing, do you mean we can throw out LegacyVM when tracing is complete?

@axic
Copy link
Member

axic commented Jul 30, 2018

I would prefer them to be separate PRs for more manageable PR size

I'm fine with that, just was wondering if it is only ignored or will it have its own PR.

I'm not sure what it has to do with tracing, do you mean we can throw out LegacyVM when tracing is complete?

Exactly.

@gumb0
Copy link
Member Author

gumb0 commented Jul 30, 2018

I plan to make another PR for aleth-inerpreter as I did for CREATE2

@codecov-io
Copy link

codecov-io commented Jul 30, 2018

Codecov Report

Merging #5134 into develop will increase coverage by 0.07%.
The diff coverage is 97.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5134      +/-   ##
===========================================
+ Coverage    59.63%   59.71%   +0.07%     
===========================================
  Files          337      337              
  Lines        27184    27247      +63     
  Branches      3170     3169       -1     
===========================================
+ Hits         16212    16270      +58     
- Misses        9888     9890       +2     
- Partials      1084     1087       +3

@gumb0 gumb0 merged commit fbf30b7 into develop Jul 31, 2018
@gumb0 gumb0 deleted the extcodehash-legacyvm branch July 31, 2018 14:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants