Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add staticheck and other fmt tools back to test #10703

Closed
spzala opened this issue May 3, 2019 · 2 comments
Closed

Add staticheck and other fmt tools back to test #10703

spzala opened this issue May 3, 2019 · 2 comments
Assignees
Labels

Comments

@spzala
Copy link
Member

spzala commented May 3, 2019

gosimple,unused,staticheck,unconvert,ineffasign,nakedret are not module-aware. They are removed from test under #10640 The module-aware versions of these tools (except gosimple and unused) need to be used when they become available. gosimple and unused have been deprecated (folded into staticcheck) as mentioned in the #10442 so they should not be added back.
A ref issue in go which is created for tracking the module support for these tools - golang/go#24661

@spzala spzala self-assigned this May 3, 2019
@spzala
Copy link
Member Author

spzala commented May 3, 2019

Hi @gyuho thought good idea that I open this issue for tracking. Since the recent go module PR merge makes #10442 obsolete thought this new issue is probably more cleaner and we can close #10442? Thanks!

@stale
Copy link

stale bot commented Apr 7, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 7, 2020
@stale stale bot closed this as completed Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

1 participant