Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING - Use IRAM_ATTR in place of ICACHE_RAM_ATTR #7921

Merged
merged 2 commits into from
Mar 14, 2021

Conversation

earlephilhower
Copy link
Collaborator

Update the core to use the define that the ESP32 uses, IRAM_ATTR, for
placing code in DRAM.

As discussed privately. Adds a deprecated warning to the old use.

Update the core to use the define that the ESP32 uses, IRAM_ATTR, for
placing code in DRAM.
@earlephilhower earlephilhower added this to the 3.0.0 milestone Mar 14, 2021
earlephilhower added a commit to earlephilhower/espsoftwareserial that referenced this pull request Mar 14, 2021
Replace ICACHE_RAM_ATTR with IRAM_ATTR in the few places it was still
present, to unify the ESP32 and ESP8266 codepaths.  ESP8266 core is
deprecating the ICACHE_RAM_ATTR define in 3.0.0:
esp8266/Arduino#7921
@earlephilhower
Copy link
Collaborator Author

Waiting on plerup/espsoftwareserial#202 to clear up warnings on SoftwareSerial.

dok-net pushed a commit to plerup/espsoftwareserial that referenced this pull request Mar 14, 2021
Replace ICACHE_RAM_ATTR with IRAM_ATTR in the few places it was still
present, to unify the ESP32 and ESP8266 codepaths.  ESP8266 core is
deprecating the ICACHE_RAM_ATTR define in 3.0.0:
esp8266/Arduino#7921
@earlephilhower earlephilhower merged commit 656a33e into esp8266:master Mar 14, 2021
@earlephilhower earlephilhower deleted the esp32iram branch March 14, 2021 23:56
markvader added a commit to markvader/WiFi-Poti-Fan that referenced this pull request Jan 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants