Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made ESP8266WebServer::client() return a reference (fixes #7075) #7080

Merged
merged 2 commits into from
Jul 17, 2020

Conversation

bblanchon
Copy link
Contributor

@bblanchon bblanchon commented Feb 13, 2020

edit from maintainer: fixes #7075

Copy link
Collaborator

@d-a-v d-a-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be no functionality changes.
ClientContext is the same in both case.
ClientType may be ssl, pointers to structs are shared too in both case.

edit: a quick test shows things are still running fine

@d-a-v d-a-v added this to the 2.7.0 milestone Feb 18, 2020
@devyte
Copy link
Collaborator

devyte commented Feb 18, 2020

I am in favor of this, in fact I completely agree to move away from return-by-value. However, there is worry that this could cause pain due to moving away from the Arduino way of return-by-value (object slicing or whatever), as has happened in the past.
Whatever the case, this is a breaking change due to a signature change, so at best it must be targeted for v3.

@devyte devyte modified the milestones: 2.7.0, 3.0.0 Feb 18, 2020
@d-a-v d-a-v merged commit c18f7cb into esp8266:master Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ESP8266WebServer::client() should return a reference
3 participants