Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI option --esp-idf-version missing in v0.3.0, alternative not working #193

Closed
rand12345 opened this issue Feb 26, 2023 · 1 comment
Closed
Labels
bug Something isn't working

Comments

@rand12345
Copy link

Bug description

Upgraded from 0.2.8 and my build scripts failed. Substituting what I think is the correct option fails.

To Reproduce

Steps to reproduce the behavior:

  1. ... cargo install espup
  2. ... espup install -v release/v4.4

$ espup install -v release/v4.4 error: invalid value 'release/v4.4' for '--toolchain-version <TOOLCHAIN_VERSION>': ⛔ Invalid toolchain version 'release/v4.4'. Verify that the format is correct: '<major>.<minor>.<patch>.<subpatch>' or '<major>.<minor>.<patch>', and that the release exists in https://github.com/esp-rs/rust-build/releases

Rolling back to v0.2.8 works fine using espup install --esp-idf-version release/v4.4. Do I have the wrong option here or is there a breaking change in the naming convention of releases?

@rand12345 rand12345 added the bug Something isn't working label Feb 26, 2023
@SergioGasquez
Copy link
Member

Hi @rand12345!

espup no longer installs esp-idf, you can see the full discussion in #154 and #182, but basically we agreed on delegating to esp-idf-sys the esp-idf installation to remove duplicated code and avoid confusion on the users.

@SergioGasquez SergioGasquez closed this as not planned Won't fix, can't repro, duplicate, stale Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants