Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit espup update and espup uninstall #168

Closed
SergioGasquez opened this issue Jan 25, 2023 · 0 comments · Fixed by #182
Closed

Revisit espup update and espup uninstall #168

SergioGasquez opened this issue Jan 25, 2023 · 0 comments · Fixed by #182
Assignees
Labels
enhancement New feature or request

Comments

@SergioGasquez
Copy link
Member

SergioGasquez commented Jan 25, 2023

Thanks @jessebraham for opening this discussion and feedback on this topic.

Motivations

At the moment, both commands depend on the config file. The config file is populated when espup install is executed but it might be deleted or a user might already come to espup with an environment installed with rust-build scripts.

If the config file is not present, instead of failing we could do some assumptions and run them successfully.

Solution

  • For espup update (WIP: https://github.com/esp-rs/espup/tree/fix/no-config-file): Since there is no way to know which version of the toolchain we have installed. (cargo +esp --version is not an option since we use an extended version of semver and, sometimes, the last digit is quite relevant). What we could do is uninstall the current version and install the required version (latest if no argument is provided).
    • It could happen that you already have the latest toolchain installed, and it would be installing the same version.
    • When updating we will populate a config file with all the information that we have, so it can be used for futures updates
  • For espup uninstall: I'm still not sure how to handle it, we could probably just delete the $RUSTUP_HOME/toolchain/esp folder.
    • Deleting anything under $HOME/.espressif could be risky as we don't know if it was installed for Rust environment of for ESP-IDF.
@SergioGasquez SergioGasquez added the enhancement New feature or request label Jan 25, 2023
@SergioGasquez SergioGasquez self-assigned this Jan 25, 2023
@SergioGasquez SergioGasquez linked a pull request Feb 14, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant