Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Compiler Warnings introduced by ESP32-C6 Support #437

Closed
bjoernQ opened this issue Mar 13, 2023 · 0 comments · Fixed by #440
Closed

Fix Compiler Warnings introduced by ESP32-C6 Support #437

bjoernQ opened this issue Mar 13, 2023 · 0 comments · Fixed by #440
Assignees

Comments

@bjoernQ
Copy link
Contributor

bjoernQ commented Mar 13, 2023

When not compiling for ESP32-C6:

warning: variant `RtcCalInternalOsc` is never constructed
   --> C:\projects\esp\esp-hal\esp-hal-common\src\rtc_cntl\mod.rs:116:5
    |
107 | pub(crate) enum RtcCalSel {
    |                 --------- variant in this enum
...
116 |     RtcCalInternalOsc = 3,
    |     ^^^^^^^^^^^^^^^^^
    |
    = note: `RtcCalSel` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
    = note: `#[warn(dead_code)]` on by default

When compiling for ESP32-C6:

warning: associated function `enable_8m` is never used
   --> C:\projects\esp\esp-hal\esp-hal-common\src\rtc_cntl\rtc\esp32c6.rs:279:8
    |
279 |     fn enable_8m(clk_8m_en: bool, _d256_en: bool) {
    |        ^^^^^^^^^
    |
    = note: `#[warn(dead_code)]` on by default

warning: associated function `get_calibration_value` is never used
   --> C:\projects\esp\esp-hal\esp-hal-common\src\rtc_cntl\rtc\esp32c6.rs:629:8
    |
629 |     fn get_calibration_value(cal_clk: RtcCalSel, slowclk_cycles: u32) -> u32 {
    |        ^^^^^^^^^^^^^^^^^^^^^

   Compiling esp-hal-smartled v0.1.0 (C:\projects\esp\esp-hal\esp-hal-smartled)
warning: `esp-hal-common` (lib) generated 2 warnings
    Finished dev [unoptimized + debuginfo] target(s) in 29.11s
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants