Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The main procmacro is not re-exported in the current published releases of esp-hal and esp-hal-embassy #1890

Closed
jessebraham opened this issue Jul 31, 2024 · 0 comments · Fixed by #2038
Assignees
Labels
bug Something isn't working package:esp-hal-embassy Issues related to the esp-hal-embassy package
Milestone

Comments

@jessebraham
Copy link
Member

There was an unfortunately oversight with the previous release of esp-hal-embassy, in that it does not re-export the esp_hal_procmacros::main macro. Since esp-hal no longer enables the esp-hal-procmacros/embassy feature it's also not exported from this package.

For the time being, workarounds are:

1.) Add esp-hal-procmacros as a direct dependency, with the embassy feature enabled, and import the macro from there
2.) Use the main branch of the repository for both packages, and the issue has been resolved in this branch

@MabezDev @bjoernQ we discussed possibly publishing an interim release of this package, we should discuss this during our meeting on Monday and come to a decision.

@jessebraham jessebraham added bug Something isn't working status:needs-attention This should be prioritized package:esp-hal-embassy Issues related to the esp-hal-embassy package labels Jul 31, 2024
@jessebraham jessebraham added this to the 0.20.0 milestone Aug 2, 2024
@jessebraham jessebraham self-assigned this Aug 7, 2024
@bugadani bugadani pinned this issue Aug 25, 2024
@MabezDev MabezDev removed the status:needs-attention This should be prioritized label Aug 29, 2024
@bugadani bugadani unpinned this issue Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working package:esp-hal-embassy Issues related to the esp-hal-embassy package
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants