Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paginate GET requests #201

Closed
anetteu opened this issue May 12, 2022 · 3 comments · Fixed by #714
Closed

Paginate GET requests #201

anetteu opened this issue May 12, 2022 · 3 comments · Fixed by #714
Assignees
Labels
backend Backend related functionality good first issue Good for newcomers improvement Improvement to existing functionality

Comments

@anetteu
Copy link
Member

anetteu commented May 12, 2022

Describe the improvement you would like to see
When receiving a GET requests for multiple entries we should restrict the amount returned using a pagination system with default parameters that may be overwritten in the query. The parameter for page size should have an upper limit.
This is in accordance with the RESTful API principles.

How will this change existing functionality?
This will throttle our API and protect it from being overloaded in the future when we might have a large amount of data being retrieved by these calls.
Better to implement it now in anticipation as it might be easy to forget in the future as the database will probably grow slowly.

How will this improvement affect the current Threat Model?
This improvement should make our API more reliable in the long run and possibly prevent downtime.

@anetteu anetteu added improvement Improvement to existing functionality backend Backend related functionality labels May 12, 2022
@tsundvoll tsundvoll added the good first issue Good for newcomers label May 18, 2022
@aeshub
Copy link
Contributor

aeshub commented Jul 17, 2022

This issue has automatically been marked as stale as there has been no activity for 60 days. Remove stale label or comment or this will be closed in 7 days.

@aeshub aeshub added the stale This issue or pull request already exists label Jul 17, 2022
@aeshub
Copy link
Contributor

aeshub commented Sep 15, 2022

This issue has automatically been marked as stale as there has been no activity for 60 days. Remove stale label or comment or this will be closed in 7 days.

@oysand oysand removed the stale This issue or pull request already exists label Nov 7, 2022
@aeshub
Copy link
Contributor

aeshub commented Jan 12, 2023

This issue has automatically been marked as stale as there has been no activity for 60 days. Remove stale label or comment or this will be closed in 7 days.

@aeshub aeshub added the stale This issue or pull request already exists label Jan 12, 2023
@aeshub aeshub removed the stale This issue or pull request already exists label Mar 13, 2023
@GodVenn GodVenn self-assigned this Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Backend related functionality good first issue Good for newcomers improvement Improvement to existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants