Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #509: pass callback on setState and setProps #617

Merged
merged 7 commits into from
Oct 11, 2016
Merged

Fixes #509: pass callback on setState and setProps #617

merged 7 commits into from
Oct 11, 2016
+121 −20

Commits on Oct 11, 2016

  1. Update docs

    @alecrobins
    alecrobins authored and Alec Robins committed Oct 11, 2016
    Configuration menu
    Copy the full SHA
    ef799ce View commit details
    Browse the repository at this point in the history

  2. Add callback to setProps and setState

    @alecrobins
    alecrobins authored and Alec Robins committed Oct 11, 2016
    Configuration menu
    Copy the full SHA
    96aaea6 View commit details
    Browse the repository at this point in the history

  3. Add tests

    @alecrobins
    alecrobins authored and Alec Robins committed Oct 11, 2016
    Configuration menu
    Copy the full SHA
    260370a View commit details
    Browse the repository at this point in the history

  4. Default cb to undefined so it doesn't count toward functions length

    @alecrobins
    alecrobins authored and Alec Robins committed Oct 11, 2016
    Configuration menu
    Copy the full SHA
    3281333 View commit details
    Browse the repository at this point in the history

  5. Add test for cb error if not function

    @alecrobins
    alecrobins authored and Alec Robins committed Oct 11, 2016
    Configuration menu
    Copy the full SHA
    faef47c View commit details
    Browse the repository at this point in the history

  6. Use batchedUpdates for setProps test

    @alecrobins
    alecrobins authored and Alec Robins committed Oct 11, 2016
    Configuration menu
    Copy the full SHA
    7ed37aa View commit details
    Browse the repository at this point in the history

  7. Use callback instead of cb

    Alec Robins committed Oct 11, 2016
    Configuration menu
    Copy the full SHA
    2183d65 View commit details
    Browse the repository at this point in the history