auto update wrappers behind a flag #1186
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR seems to be reasonable to me. |
ljharb
requested changes
Dec 30, 2017
|
|
||
| it('should have updated output after an asynchronous setState', (done) => { | ||
| const wrapper = mount(<Test />, { autoUpdate: true }); | ||
| wrapper.find('.async-btn').simulate('click'); |
There was a problem hiding this comment.
i'd prefer to avoid simulate; can this do .prop('onClick')() instead?
| @@ -675,7 +683,7 @@ class ReactWrapper { | |||
| */ | |||
| parents(selector) { | |||
| const allParents = this.wrap( | |||
| this.single('parents', n => parentsOfNode(n, this[ROOT].getNodeInternal())), | |||
| this.single('parents', n => parentsOfNode(n, this[ROOT][NODE])), | |||
There was a problem hiding this comment.
This seems like it might be a bugfix that should go in separately from an autoUpdate option?
|
@jwbay are you no longer interested in continuing this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restores the auto update feature introduced by #490 for v3, but behind a feature flag.
mountnow needs the same treatment to keep the tree in sync that shallow used to. Fixes #1175.For what it's worth, since pre-v3 both shallow and mount essentially auto-updated by default, the only Enzyme tests that break without the flag checks are these two, which are fixable by asserting with deep equality if that's on the table.
https://github.com/airbnb/enzyme/blob/106b5d14c79a1dfc4d3ee13f87b13ffb609c5c4a/packages/enzyme-test-suite/test/ReactWrapper-spec.jsx#L3696-L3710