Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of react-reconciler/reflection #1539

Closed
aweary opened this issue Feb 24, 2018 · 2 comments
Closed

Remove use of react-reconciler/reflection #1539

aweary opened this issue Feb 24, 2018 · 2 comments

Comments

@aweary
Copy link
Collaborator

aweary commented Feb 24, 2018

See #1399 (comment) for details. This seemed like a good idea at the time, but it will probably cause headaches in the future. We need to either just revert #1399 or think of a better solution. Related to #1538, maybe we could have react-is/reflection?

Either way, we should probably undo this.

@ljharb
Copy link
Member

ljharb commented Feb 24, 2018

I’m fine reverting, but would it be better to expose an actual synced package for this?

@ljharb
Copy link
Member

ljharb commented Sep 1, 2018

This is done for the 16 adapter, and future adapters, in #1778 / #1790.

@ljharb ljharb closed this as completed Sep 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants