ReactWrapper#{html, render} should handle null children

enzymejs · Feb 16, 2016 · face3d2 · face3d2
1 parent 45d9343
commit face3d2
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 2 deletions.
diff --git a/src/ReactWrapper.js b/src/ReactWrapper.js
@@ -342,7 +342,10 @@ export default class ReactWrapper {
    * @returns {String}
    */
   html() {
-    return this.single(n => findDOMNode(n).outerHTML.replace(/\sdata-reactid+="[^"]+"/g, ''));
+    return this.single(n => {
+      const node = findDOMNode(n);
+      return node === null ? null : node.outerHTML.replace(/\sdata-reactid+="[^"]+"/g, '');
+    });
   }
 
   /**
@@ -353,7 +356,8 @@ export default class ReactWrapper {
    * @returns {CheerioWrapper}
    */
   render() {
-    return cheerio.load(this.html()).root();
+    const html = this.html();
+    return html === null ? cheerio() : cheerio.load(html).root();
   }
 
   /**

diff --git a/test/ReactWrapper-spec.js b/test/ReactWrapper-spec.js
@@ -1763,4 +1763,18 @@ describeWithDOM('mount', () => {
     });
   });
 
+  it('works with components that return null', () => {
+    class Foo extends React.Component {
+      render() {
+        return null;
+      }
+    }
+    const wrapper = mount(<Foo />);
+    expect(wrapper).to.have.length(1);
+    expect(wrapper.type()).to.equal(Foo);
+    expect(wrapper.html()).to.equal(null);
+    const rendered = wrapper.render();
+    expect(rendered.length).to.equal(0);
+    expect(rendered.html()).to.equal(null);
+  });
 });