Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fixes #932] fix ember-canary test scenario #933

Merged
merged 2 commits into from
Aug 23, 2021
Merged

Conversation

stefanpenner
Copy link
Collaborator

@stefanpenner stefanpenner commented Aug 23, 2021

[fixes #932]

Problem 1:

description of problem: emberjs/ember.js#19680 (comment)
fix in @ember/test-helpers: emberjs/ember-test-helpers#1110

Problem 2:

emberjs/ember.js#19724


** note: this PR does not include tests only because the existing tests already cover this scenario, and are in-fact what caught the issue in the first place **

@stefanpenner
Copy link
Collaborator Author

Ok, this appears to fix one problem. But, there appears to be an additional issue, this time with the template compiler (for beta and canary scenarios). Looking into that now...

…ber-template-lint

Ember-cli-template-lint is deprecated, and now incompatible with ember 4.x
@stefanpenner stefanpenner merged commit a122d4d into master Aug 23, 2021
@stefanpenner stefanpenner deleted the fix-canary-scenario branch August 23, 2021 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ember-canary packages/utils appears to be failing
2 participants