Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advance RFC #0800 "Typescript Adoption Plan" to Stage Ready for Release #868

Merged
merged 5 commits into from
Aug 24, 2023

Conversation

emberjs-rfcs-bot
Copy link
Collaborator

@emberjs-rfcs-bot emberjs-rfcs-bot commented Nov 23, 2022

Advance #800 to the Ready For Release Stage

Summary

This pull request is advancing the RFC to the Ready For Release Stage.

An FCP is required before merging this PR to advance.

Upon merging this PR, automation will open a draft PR for this RFC to move to the Released Stage.

Ready for Release Stage Description

This stage is complete when the implementation is complete according to plan outlined in the RFC, and is in harmony with any changes in Ember that have occurred since the RFC was first written. This includes any necessary learning materials. At this stage, features or deprecations may be available for use behind a feature flag, or with an optional package, etc.

For codebase changes, there are no open questions that are anticipated to require breaking changes; the Ember team is ready to commit to the stability of any interfaces exposed by the current implementation of the feature.

This stage should include a list of criteria for determining when the proposal can be considered Recommended after being Released.

An FCP is required to move into this stage.

Each Ember core team will be requested as a reviewer on the PR to move into this stage. A representative of each team adds a review. If a team does not respond to the request, and after the conclusion of the FCP, it is assumed that the release may proceed.

Checklist to move to Ready for Release

  • Implementation is complete according to plan outlined in the RFC, with any adjustments noted in the RFC
  • Any necessary learning materials have been updated
  • The Ember team is ready to commit to the stability of any interfaces exposed by the current implementation of the feature
  • Criteria for moving to the Recommended Stage has been filled out
  • This PR has been converted from a draft to a regular PR and the Final Comment Period label has been added to start the FCP
  • Each team has been added as a reviewer to the PR at the start of the FCP
    • Framework @emberjs/framework
    • Data @emberjs/ember-data-core
    • CLI @emberjs/cli
    • Learning @emberjs/learning-core
    • Typescript @emberjs/typescript-core
    • Steering @emberjs/steering

Criteria for moving to Recommended (required)

Note This is a draft, there is more to be filled out here!

A set of criteria for moving this RFC to the Recommended Stage, following release:

  1. The Guides have been updated to include TS inline.
  2. New sections of the Guides have been added to cover using TypeScript and Glint.
  3. The API docs have been updated.
  4. The <template> feature has been Released (it does not need to be Recommended).

Track Implementation

Note This is a draft, there is more to be filled out here!

@emberjs-rfcs-bot emberjs-rfcs-bot added RFC Advancement S-Ready for Release PR to move to the Ready for Release Stage labels Nov 23, 2022
@chriskrycho
Copy link
Contributor

Requires landing #902, which updates #800 with learnings from implementation.

@kategengler kategengler changed the title Advance RFC #0800 to Stage Ready for Release Advance RFC #0800 "Typescript Adoption Plant" to Stage Ready for Release Feb 9, 2023
@ef4 ef4 changed the title Advance RFC #0800 "Typescript Adoption Plant" to Stage Ready for Release Advance RFC #0800 "Typescript Adoption Plan" to Stage Ready for Release Mar 1, 2023
@wagenet wagenet added the E-Polaris Work for the Polaris Edition label Mar 23, 2023
@gitKrystan
Copy link
Contributor

Per TS core meeting: should bump this to released

@wagenet wagenet marked this pull request as ready for review August 24, 2023 17:46
@wagenet
Copy link
Member

wagenet commented Aug 24, 2023

Merging since the plan is already released.

@wagenet wagenet merged commit ccd8a18 into master Aug 24, 2023
8 checks passed
@delete-merged-branch delete-merged-branch bot deleted the advance-rfc-0800 branch August 24, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E-Polaris Work for the Polaris Edition RFC Advancement S-Ready for Release PR to move to the Ready for Release Stage T-TypeScript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants