Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Make deprecations throw when the until for ember-source has passed #20669

Merged
merged 3 commits into from
Mar 26, 2024
Merged

[FEATURE] Make deprecations throw when the until for ember-source has passed #20669

merged 3 commits into from
Mar 26, 2024

Commits on Mar 26, 2024

  1. Make deprecations throw when the until for ember-source has passed 

    - Add a new `deprecateUntil` that checks whether a deprecation has been
  removed and throws if it has. This explicitly uses `throw` and not
assert so that it will remain in production builds. This function should
be used internally in ember-source in place of `deprecate`.
- Add utilities `testIf` and `testUnless` to guard tests based on
  whether a deprecation has been removed. Uses this for the existing
deprecation on @ember/routing
- Add a query param to tests `overridedeprecationversion` that takes a
  version to be the current version for removing deprecation purposes
- Add a CI build to use the above to test with deprecations broken
    @kategengler
    kategengler committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    f25aa2f View commit details
    Browse the repository at this point in the history

  2. Didn't need replaceAll after all

    @kategengler
    kategengler committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    0a7b889 View commit details
    Browse the repository at this point in the history

  3. Update test that was incidentally using deprecated behavior

    @kategengler
    kategengler committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    399a548 View commit details
    Browse the repository at this point in the history