[BUGFIX LTS] Improve SafeString type tests, include in preview types #20374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriskrycho
force-pushed
the
just-SafeString
branch
from
ca0501b
to
6bd106a
Compare
chriskrycho
changed the title
Building on the previous, beta-only PR, update the type tests to check for the constructibility of the type, and make sure it is included in the types users can actually consume. (This is the part we will end up backporting to LTS!)
chriskrycho
force-pushed
the
just-SafeString
branch
from
6bd106a
to
73c0039
Compare
wagenet
approved these changes
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on the previous, beta-only PR (#20373), update the type tests to check for the constructibility of the type, and make sure it is included in the types users can actually consume. (This is the part we will end up backporting to LTS!)