Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX LTS] Controller queryParams are readonly #20296

Merged
merged 1 commit into from
Dec 1, 2022

Conversation

wagenet
Copy link
Member

@wagenet wagenet commented Dec 1, 2022

  • Update DefinitelyTyped

@chriskrycho
Copy link
Contributor

Blergh, I realized after approving this when looking at the DT PR that this doesn't actually help us: this change doesn't actually make queryParams be a ReadonlyArray, since subclasses can make it a regular array—and in fact that's what we're doing explicitly in the tests here. 😩 So we should revert this.

playground

@wagenet wagenet deleted the controller-query-params-readonly branch December 5, 2022 17:25
@wagenet
Copy link
Member Author

wagenet commented Dec 5, 2022

All I wanted was for it to allow Readonly object to be passed in for queryParams, e.g. queryParams = Object.freeze({ ... })

@chriskrycho chriskrycho changed the title Controller queryParams are readonly [BUGFIX LTS] Controller queryParams are readonly Dec 6, 2022
@chriskrycho chriskrycho added Bug TypeScript Work on Ember’s types labels Dec 6, 2022
@chriskrycho
Copy link
Contributor

I'm noting this one for back-port to LTS as well as beta and stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug TypeScript Work on Ember’s types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants