[BUGFIX release] Fix unsafe internal cast for NativeArray #20227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriskrycho
changed the title
chriskrycho
force-pushed
the
bugfix-ts-4.9
branch
2 times, most recently
from
362b769
to
1306987
Compare
- For casting to `NativeArray` from `T[] & EmberArray<unknown>`: we do not have enough information to be able to tell TypeScript that the cast is safe here (and likely never will). TS 4.9 seems to handle the intersection type more robustly, though it is not yet documented. Here we make the cast from `T[] & EmberArray<T>` to `NativeArray<T>` even *more* explicitly unsafe via an `as unknown` intermediary cast. - For handling a proxy getter: TS' intersection of the `this` type for the `get()` method on a proxy receiver object used in `CoreObject` now flags up that the type of `this` may *not* be exactly `CoreObject`. Using `typeof this` in that intersection instead allows TS to see that the trap is safe.
chriskrycho
force-pushed
the
bugfix-ts-4.9
branch
from
1306987
to
04d3a88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For casting to
NativeArrayfromT[] & EmberArray<unknown>: we do not have enough information to be able to tell TypeScript that the cast is safe here (and likely never will). TS 4.9 seems to handle the intersection type more robustly, though it is not yet documented. Here we make the cast fromT[] & EmberArray<T>toNativeArray<T>even more explicitly unsafe via anas unknownintermediary cast.For handling a proxy getter: TS' intersection of the
thistype for theget()method on a proxy receiver object used inCoreObjectnow flags up that the type ofthismay not be exactlyCoreObject. Usingtypeof thisin that intersection instead allows TS to see that the trap is safe.