Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert packages/ember to TS #20175

Merged
merged 2 commits into from
Oct 28, 2022
Merged

Convert packages/ember to TS #20175

merged 2 commits into from
Oct 28, 2022

Commits on Oct 27, 2022

  1. Convert packages/ember to TS

    @wagenet @chriskrycho
    wagenet authored and chriskrycho committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    8bddebe View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2022

  1. Revert to defineProperty for get/set on Ember namespace 

    While we might be able to make the change over to using native getters
and setters in a future PR, we want this change to be exactly and only
a type conversion, exactly preserving the previous behavior. Switching
back to using `Object.defineProperty()` for the getters and setters
defined on the `Ember` namespace preserves the previous behavior, which
our tests correctly caught for us!
    @chriskrycho
    chriskrycho committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    9cf853d View commit details
    Browse the repository at this point in the history