New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call _routerMicrolib.clean() to cleanup properties on Router #19777

Closed

step2yeung wants to merge 1 commit into emberjs:master from step2yeung:syeung/cleanupRouter

step2yeung commented Oct 8, 2021

Fix for #19773

Note: This may not be the best fix, although I have not found the correct place to clean up all Router constructors. See issue for more info.

TODO:

Use latest version of router.js which exposes cleanup()


          Call _routerMicrolib.clean() to cleanup properties on Router

ed4759b

Author

step2yeung commented Oct 14, 2021

Closing this PR out. This just fixes the symptom. Kris Selden & Rob Jackson are both spending time investigating the root cause.

step2yeung closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet