[BUGFIX lts] ensure deserializeQueryParam is called for lazy routes
#19697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
changed the title
deserializeQueryParam is called for lazy routesdeserializeQueryParam is called for lazy routes
rwjblue
requested changes
Aug 5, 2021
rwjblue
approved these changes
Aug 5, 2021
This was referenced Aug 5, 2021
40 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it's possible for
deserializeQueryParamto not be called on lazy routes, which can break deserialization of query params. As soon asgetFullQueryParamsis called it caches query params state regardless of whether all routes have resolved; this PR updates to only cache state if all routes have resolved, however we still process query params in both of these cases. I've also added a test-case here to prevent this from regressing in the future.