Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLEANUP] Remove deprecated jQuery integration #19551

Closed
wants to merge 2 commits into from

Conversation

simonihmig
Copy link
Contributor

This removes the Ember.$() and this.$() jQuery integration, deprecated by RFC386.

There is still more work to do, but I wanted to keep the scope of PRs small:

Note: as a breaking change, this should only get merged when it's clear that current master represents the "4.0 train" - not 100% sure if that decision has been taken already!?

@rwjblue
Copy link
Member

rwjblue commented May 24, 2021

will likely need a rebase?

@simonihmig
Copy link
Contributor Author

will likely need a rebase?

I had to fix a linting error, but other than that this should be ok!

@rwjblue
Copy link
Member

rwjblue commented May 27, 2021

Due to some complications with 3.27's migration to use real modules (and the resulting massive number of deprecations being triggered) we are not 100% certain (yet) that 4.0 will be the version just after v3.28.

In order to move ahead with v4.0 cleanup efforts (like this one), I've pushed a new branch that can serve as the target for breaking change PR's: https://github.com/emberjs/ember.js/tree/v4-cleanup.

I've updated this PR to target that branch, can you rebase against that branch and push an update?

Expand for an example of the commands needed for that rebase.
# starting from this PR's branch

git fetch origin
git rebase origin/v4-cleanup

# fix any conflicts

# push the rebase
git push -f

Those steps should be roughly what you need, but might need some tweaks based on your local repository setup (e.g. if you don't use origin for the main emberjs/ember.js repo you might have to use another remote name there).

Thank you for helping us push things forward!

@rwjblue rwjblue changed the base branch from master to v4-cleanup May 27, 2021 15:00
@simonihmig
Copy link
Contributor Author

Done

@simonihmig simonihmig changed the title [Ember 4.0] Remove deprecated jQuery integration [CLEANUP] Remove deprecated jQuery integration May 27, 2021
@mixonic
Copy link
Sponsor Member

mixonic commented Jul 17, 2021

I'm not clear on where we sit with the v4-cleanup stuff now. master is currently 4.0, so I would land this if it was pointed there.

@mixonic mixonic mentioned this pull request Jul 18, 2021
58 tasks
@rwjblue rwjblue closed this Jul 18, 2021
@rwjblue rwjblue deleted the branch emberjs:v4-cleanup July 18, 2021 02:05
@mixonic
Copy link
Sponsor Member

mixonic commented Jul 18, 2021

@simonihmig this PR was auto-closed when v4-cleanup was merged to master. Can you re-open for us to review/merge against master? This is excellent work and I don't want to lose it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants