Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX LTS] Prevent transformation of block params called attrs #19472

Merged

Conversation

Windvis
Copy link
Contributor

@Windvis Windvis commented Mar 22, 2021

This prevents the transform-attrs-into-args transform plugin from transforming block params that are named "attrs" and are yielded by components.

The following snippet would render nothing before this change even though a value was yielded from the component template:

<Component as |attrs|>{{attrs}}</Component>

This prevents the `transform-attrs-into-args` transform plugin from transforming block params that are named "attrs" and are yielded by components.
@Windvis
Copy link
Contributor Author

Windvis commented Mar 22, 2021

Naming things is not my strongest skill and I'm not sure if I'm using the correct terms, so do let me know if I need to change / rewrite some sentences somewhere!

Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!!!

@rwjblue rwjblue merged commit bb76291 into emberjs:master Mar 22, 2021
@rwjblue rwjblue added the Bug label Mar 22, 2021
@Windvis Windvis deleted the bugfix/transform-attrs-into-args-block-params branch March 23, 2021 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants