Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use positional and named as the argument names in ember g helper blueprint #19462

Merged
merged 1 commit into from
Mar 17, 2021
Merged

Use positional and named as the argument names in ember g helper blueprint #19462

merged 1 commit into from
Mar 17, 2021

Conversation

bertdeblock
Copy link
Member

rwjblue
rwjblue reviewed Mar 17, 2021
View reviewed changes
Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally 👍, need to figure out the remaining test failures

@bertdeblock
Copy link
Member Author

Rebased to kick off CI again and everything is fine now. Not sure what made the BrowserStack tests fail initially.

@rwjblue rwjblue changed the title Rename helper arguments in blueprints Use positional and named as the argument names in ember g helper blueprint Mar 17, 2021
@rwjblue rwjblue merged commit df149be into emberjs:master Mar 17, 2021
@locks locks mentioned this pull request May 20, 2021
Merged
@bertdeblock bertdeblock mentioned this pull request Jul 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bertdeblock @rwjblue