Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hasBlock and hasBlockParams deprecation messages #19374

Merged
merged 1 commit into from
Feb 3, 2021
Merged

Add hasBlock and hasBlockParams deprecation messages #19374

merged 1 commit into from
Feb 3, 2021

Conversation

patocallaghan
Copy link
Contributor

@patocallaghan patocallaghan commented Feb 2, 2021 •
edited
Loading

Adds a deprecation for hasBlock and hasBlockParams. RFC

key: has-block-and-has-block-params (taken from ember-learn/deprecation-app#778)

`hasBlock` is deprecated. Use `has-block` instead.

`hasBlockParams` is deprecated. Use `has-block-params` instead.

/cc @pzuraq

@patocallaghan patocallaghan marked this pull request as ready for review February 3, 2021 00:17
@pzuraq pzuraq merged commit b480c96 into emberjs:master Feb 3, 2021
@pzuraq
Copy link
Contributor

pzuraq commented Feb 3, 2021

Thanks for doing this, really appreciate it!

@patocallaghan patocallaghan deleted the patoc/has-block-deprecation branch February 3, 2021 07:21
@patocallaghan patocallaghan mentioned this pull request Feb 3, 2021
Merged
This was referenced Mar 23, 2021
Merged
Merged
@jaredgalanis jaredgalanis mentioned this pull request Mar 31, 2021
Merged
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pzuraq pzuraq pzuraq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patocallaghan @pzuraq