[FEAT] Enables Helper Managers and invokeHelper
#19182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
approved these changes
Oct 3, 2020
pzuraq
commented
Oct 3, 2020
| export function invokeHelper( | ||
| context: object, | ||
| definition: HelperDefinition, | ||
| computeArgs: (context: object) => Partial<Arguments> | ||
| computeArgs?: (context: object) => Partial<Arguments> |
There was a problem hiding this comment.
Mistake in the typings here but the SimpleArgsProxy had the correct typings
pzuraq
force-pushed
the
enable-helper-managers-invoke-helper
branch
2 times, most recently
from
7f14b2a
to
a5bdd26
Compare
|
Failures are due to inconsistent error messages across browsers for assigning a value on a frozen object, going to update that test to just ensure that args are frozen using |
Enables the Helper Manager and `invokeHelper` feature flags, and adds API documentation for them.
pzuraq
force-pushed
the
enable-helper-managers-invoke-helper
branch
from
a5bdd26
to
efd895f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables the Helper Manager and
invokeHelperfeature flags, and addsAPI documentation for them.