[BUGFIX release] Ensure AST transforms using in-element work properly.
#18958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
force-pushed
the
fix-in-element-ast-transforms
branch
from
574e8ce
to
51b76de
Compare
chancancode
approved these changes
May 8, 2020
Prior to this, an AST transform that adds an `in-element` usage would fail subtly. This was fixed in glimmerjs/glimmer-vm#1086.
rwjblue
force-pushed
the
fix-in-element-ast-transforms
branch
from
51b76de
to
5a8c72a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this, an AST transform that adds an
in-elementusage would fail subtly. This was fixed in glimmerjs/glimmer-vm#1086.Fixes the issue identified (and worked around) in #18727.