[BUGFIX beta] Add error for modifier manager without capabilities. #18919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pzuraq
approved these changes
Apr 23, 2020
pzuraq
reviewed
Apr 23, 2020
packages/@ember/-internals/glimmer/tests/integration/custom-modifier-manager-test.js
Outdated
Show resolved
Hide resolved
Now that the deprecation is removed (in 3.19.0-beta.1) folks that were previously getting the deprecation would get a very bizarre error: ``` Cannot read property 'disableAutoTracking' of undefined ``` This adds a much more helpful assertion.
rwjblue
force-pushed
the
error-on-missing-capabilities
branch
from
35db9bf
to
babe75d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the deprecation is removed (in 3.19.0-beta.1) folks that were previously getting the deprecation would get a very bizarre error:
This adds a much more helpful assertion.