Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated implicit-modifier-manager-capabilities #18832

Merged
merged 2 commits into from
Mar 23, 2020
Merged

Remove deprecated implicit-modifier-manager-capabilities #18832

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2fcedf
Remove deprecated `implicit-modifier-manager-capabilities`
btecu Mar 20, 2020
4c633b0
remove test for modifier capabilities deprecation
locks Mar 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 1 addition & 27 deletions packages/@ember/-internals/glimmer/lib/modifiers/custom.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { Factory } from '@ember/-internals/owner';
import { getDebugName } from '@ember/-internals/utils';
import { assert, deprecate } from '@ember/debug';
import { assert } from '@ember/debug';
import { DEBUG } from '@glimmer/env';
import { CapturedArguments, Dict, ModifierManager, VMArguments } from '@glimmer/interfaces';
import {
Expand Down Expand Up @@ -33,19 +33,6 @@ export function capabilities(
managerAPI: string,
optionalFeatures: OptionalCapabilities = {}
): Capabilities {
if (managerAPI !== '3.13') {
managerAPI = '3.13';

deprecate(
'Modifier manager capabilities now require you to pass a valid version when being generated. Valid versions include: 3.13',
false,
{
until: '3.17.0',
id: 'implicit-modifier-manager-capabilities',
}
);
}

assert('Invalid modifier manager compatibility specified', managerAPI === '3.13');

return {
Expand Down Expand Up @@ -145,19 +132,6 @@ class InteractiveCustomModifierManager<ModifierInstance>

let instance = definition.delegate.createModifier(ModifierClass, capturedArgs.value());

if (delegate.capabilities === undefined) {
delegate.capabilities = capabilities('3.13');

deprecate(
'Custom modifier managers must define their capabilities using the capabilities() helper function',
false,
{
until: '3.17.0',
id: 'implicit-modifier-manager-capabilities',
}
);
}

return new CustomModifierState(element, delegate, instance, capturedArgs);
}

Expand Down
43 changes: 0 additions & 43 deletions packages/@ember/-internals/glimmer/tests/integration/custom-modifier-manager-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,49 +103,6 @@ moduleFor(
runTask(() => set(this.context, 'truthy', true));
}

'@test requires modifier capabilities'() {
class WithoutCapabilities extends CustomModifierManager {
constructor(owner) {
super(owner);
this.capabilities = undefined;
}
}

let ModifierClass = setModifierManager(
owner => {
return new WithoutCapabilities(owner);
},
EmberObject.extend({
didInsertElement() {},
didUpdate() {},
willDestroyElement() {},
})
);

this.registerModifier(
'foo-bar',
ModifierClass.extend({
didUpdate() {},
didInsertElement() {},
willDestroyElement() {},
})
);

expectDeprecation(() => {
this.render('<h1 {{foo-bar truthy}}>hello world</h1>');
}, /Custom modifier managers must define their capabilities/);
}

'@test modifier capabilities require a version'() {
expectDeprecation(() => {
modifierCapabilities();
}, /Modifier manager capabilities now require you to pass a valid version when being generated/);

expectDeprecation(() => {
modifierCapabilities('aoeu');
}, /Modifier manager capabilities now require you to pass a valid version when being generated/);
}

'@test associates manager even through an inheritance structure'(assert) {
assert.expect(5);
let ModifierClass = setModifierManager(
Expand Down