[BUGFIX release] Ensure model can be observed by sync observers #18476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chancancode
reviewed
Oct 9, 2019
| } | ||
|
|
||
| async '@test model can be observed with sync observers'(assert) { | ||
| let observerDidRun = false; |
There was a problem hiding this comment.
nit: may as well make this a counter and assert that it fired exactly once
chancancode
reviewed
Oct 9, 2019
| model: EMBER_METAL_TRACKED_PROPERTIES ? tracked() : null, | ||
| model: computed({ | ||
| get() { | ||
| return this[MODEL]; |
There was a problem hiding this comment.
We may want to make this non-enumerable if there is an easy way to do it, but if it's too annoying it's not a big deal.
There was a problem hiding this comment.
The only way to do it currently is something I think we'd rather deprecate sooner rather than later (it requires some not-so-nice prototype chain manipulation), so I'd rather not for the moment
pzuraq
force-pushed
the
bugfix/ensure-model-is-observable-sync
branch
from
93cf8c7
to
17b3e9a
Compare
This is a compatibility change, otherwise sync observers will not be able to watch the model property of controllers at all. Also fixes the naming of the final flag to Observable#addObserver and Observable#removeObserver
pzuraq
force-pushed
the
bugfix/ensure-model-is-observable-sync
branch
from
17b3e9a
to
1d565fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a compatibility change, otherwise sync observers
will not be able to watch the model property of controllers
at all. Also fixes the naming of the final flag to Observable#addObserver
and Observable#removeObserver
Fixes #18427