[BUGFIX lts] Ensure transpiled builds work when babel helpers are not externalized #18291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Helpers were no longer being externalized in our builds, which adds a significant amount to the final payload. This adds them back into the build. Also fixes an issue where the template compiler was not being included in the vendor folder for Ember.
rwjblue
approved these changes
Aug 20, 2019
|
Failures in the browserstack jobs for IE and Safari (didn't look for others): |
|
Yeah, it’s async/await, need to figure out how to compile it so those don’t go to babel-helpers |
pzuraq
force-pushed
the
bugfix/externalize-helpers
branch
from
321ec0b
to
4bf158f
Compare
rwjblue
changed the title
timiyay
pushed a commit
to timiyay/ember.js
that referenced
this pull request
Nov 27, 2019
Helpers were no longer being externalized in our builds, which adds a significant amount to the final payload. This adds them back into the build. Also fixes an issue where the template compiler was not being included in the vendor folder for Ember. ensure async helpers are inlined in dev Cherry-picked from PR emberjs#18291
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helpers were no longer being externalized in our builds, which adds a
significant amount to the final payload. This adds them back into the
build.
Also fixes an issue where the template compiler was not being included
in the vendor folder for Ember.