[BUGFIX beta] Allow CPs to depend on nested args #18274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
reviewed
Aug 16, 2019
CP chaining on nested args was not setup properly in the last couple of merges. This fixes and adds a test case.
pzuraq
force-pushed
the
bugfix/ensure-cps-can-depend-on-nested-args
branch
from
344b738
to
ff69948
Compare
vitch
pushed a commit
to vitch/ember-octane-test
that referenced
this pull request
Aug 16, 2019
And latest `ember-source`. Locally I'm `yarn link`ing to emberjs/ember.js#18274 to see the behaviour...
rwjblue
approved these changes
Aug 16, 2019
delete-merged-branch
bot
deleted the
bugfix/ensure-cps-can-depend-on-nested-args
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CP chaining on nested args was not setup properly in the last couple of
merges. This fixes and adds a test case.