Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX beta] Fix issues with SSR rehydration of <title>. #18273

Merged
merged 1 commit into from
Sep 20, 2019

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Aug 16, 2019

No description provided.

@rwjblue
Copy link
Member Author

rwjblue commented Aug 16, 2019

CI failure seems very unrelated 🤔

not ok 14 Edge 18.18362 - [3 ms] - Engine initializers:  initializers require proper 'name' and 'initialize' properties
    ---
        actual: >
            null
        stack: >
               at Anonymous function (http://127.0.0.1:7774/217628314952/dist/tests/qunit/qunit.js:3257:7)
               at processTaskQueue (http://127.0.0.1:7774/217628314952/dist/tests/qunit/qunit.js:2623:6)
               at Anonymous function (http://127.0.0.1:7774/217628314952/dist/tests/qunit/qunit.js:2627:8)
               at run (http://127.0.0.1:7774/217628314952/dist/tests/polyfill.js:674:14)
               at Anonymous function (http://127.0.0.1:7774/217628314952/dist/tests/polyfill.js:691:31)
               at flush (http://127.0.0.1:7774/217628314952/dist/tests/polyfill.js:471:10)
        message: >
            Died on test #1    at generateTest (http://127.0.0.1:7774/217628314952/dist/tests/ember-tests.js:107409:9)
               at Set.prototype.forEach (native code)
               at setupTestClass (http://127.0.0.1:7774/217628314952/dist/tests/ember-tests.js:107393:5)
               at Anonymous function (http://127.0.0.1:7774/217628314952/dist/tests/ember-tests.js:107340:7)
               at Anonymous function (http://127.0.0.1:7774/217628314952/dist/tests/ember-tests.js:106732:9)
               at processModule (http://127.0.0.1:7774/217628314952/dist/tests/qunit/qunit.js:1191:5)
               at module$1 (http://127.0.0.1:7774/217628314952/dist/tests/qunit/qunit.js:1216:4): [object Object]
        negative: >
            false
        browser log: |

@pzuraq
Copy link
Contributor

pzuraq commented Aug 16, 2019

FWIW this is the same test that was causing the assert issue we saw on the tracked props PR. For some reason, when running all of the tests, by the end of this test Ember.assert would be stubbed and wouldn't go back to normal. This was only if you ran all of the tests.

@rwjblue
Copy link
Member Author

rwjblue commented Aug 16, 2019

Rebased, hopefully I had just not included that Edge Ember.assert reset fix you did. 🤞

@rwjblue
Copy link
Member Author

rwjblue commented Sep 20, 2019

Eeck. I completely forgot about this 😩. Rebased and updated to BUGFIX release.

@rwjblue rwjblue merged commit 3aeaad1 into emberjs:master Sep 20, 2019
@rwjblue rwjblue deleted the update-glimmer-m branch September 20, 2019 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants