Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX beta] join runloop in Helper#recompute #18110

Merged

Conversation

buschtoens
Copy link
Contributor

Fixes #14774.

Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just wanted to confirm that this test failed prior to adding the run.join, right?

@buschtoens
Copy link
Contributor Author

@rwjblue Correct, it did! ☺️

@rwjblue rwjblue merged commit 25cff51 into emberjs:master Jun 18, 2019
@rwjblue
Copy link
Member

rwjblue commented Jun 18, 2019

Thank you!

@buschtoens buschtoens deleted the 14774-fix-helper-recompute-runloop branch June 18, 2019 13:24
@Windvis
Copy link
Contributor

Windvis commented Nov 6, 2019

According to the LTS info page LTS releases receive bugfixes for 30 weeks. Doesn't that mean that this fix should have been backported to the 3.8 LTS since the PR was merged in june? 😄

Copy link
Member

rwjblue commented Nov 6, 2019

Sure, if we had thought about it at the time, we definitely could have. At this point 3.8 is receiving security fixes only, so it will not get this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ember 2.10.0 helper recompute bug
3 participants