[FEAT] Adds more assertions to native decorators, and parenless invocation #17604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pzuraq
force-pushed
the
feat/decorator-assertions-and-parenless
branch
from
ed9712d
to
671231a
Compare
rwjblue
reviewed
Feb 12, 2019
| `Only one computed property decorator can be applied to a class field or accessor, but '${key}' was decorated twice. You may have added the decorator to both a getter and setter, which is unecessary.`, | ||
| isClassicDecorator || | ||
| !propertyDesc.get || | ||
| !propertyDesc.get.toString().includes('CPGETTER_FUNCTION') |
There was a problem hiding this comment.
This relies on String.prototype.includes, is that available on IE11?
There was a problem hiding this comment.
ah, good point, will switch to indexof
pzuraq
force-pushed
the
feat/decorator-assertions-and-parenless
branch
2 times, most recently
from
b5cd71b
to
d2c8ffb
Compare
…ation This upstreams a couple of helpful assertions from ember-decorators, and also adds the ability to call `@service`, `@controller`, and `@computed` without parens.
pzuraq
force-pushed
the
feat/decorator-assertions-and-parenless
branch
from
d2c8ffb
to
095cdd8
Compare
rwjblue
approved these changes
Feb 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upstreams a couple of helpful assertions from ember-decorators,
and also adds the ability to call
@service,@controller, and@computedwithout parens (only in native)