Add failing test ensuring that splattributes can be forwarded. #17146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
force-pushed
the
forwarding-splattributes
branch
from
06a5772
to
4073c1a
Compare
|
If anyone has the cycles to help (@cibernox?), PR-ing a failing test to https://github.com/glimmerjs/glimmer-vm (and maybe cc @wycats there 😄) would help speed up the investigation |
|
(It may also have been fixed on glimmer-vm master, so you couldn't get the test to fail it's probably still worth PR-ing there) |
|
I am free to help tomorrow all day. Pairing or anything. |
cibernox
added a commit
to cibernox/glimmer
that referenced
this pull request
Dec 23, 2018
rwjblue
pushed a commit
to cibernox/glimmer
that referenced
this pull request
Jan 18, 2019
rwjblue
pushed a commit
to glimmerjs/glimmer-vm
that referenced
this pull request
Jan 22, 2019
Extracted from emberjs/ember.js#17146 (cherry picked from commit 2a42ddb)
rwjblue
pushed a commit
to glimmerjs/glimmer-vm
that referenced
this pull request
Jan 22, 2019
Extracted from emberjs/ember.js#17146 (cherry picked from commit 2a42ddb)
rwjblue
pushed a commit
to glimmerjs/glimmer-vm
that referenced
this pull request
Jan 24, 2019
Extracted from emberjs/ember.js#17146 (cherry picked from commit 2a42ddb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.