Add RFC 232 variant detector for mocha & component blueprints

[Dhaulagiri]

Addresses #16863 by adding logic to detect when rfc 232-style tests should be used with ember-mocha 0.14 and adds component rendering and unit test blueprints

[Dhaulagiri]

@Turbo87 @rwjblue I'd like to get some momentum behind the remaining items in the quest issue, but I don't want to get too far before validating that the work in this PR is the right direction. Can you let me know any feedback??

[simonihmig]

LGTM! 👍

[kateeliza24]

Thx 1MU6qPwUi41Lcv6y1Ext8X1vD1A2xtvHxp เมื่อ 18 ส.ค. 2018 7:16 AM "Simon Ihmig" <notifications@github.com> เขียนว่า *@simonihmig* approved this pull request. LGTM! 👍 — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#16865 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AoYUdUfoQBdLcyBgwxlnGinBq7QxkzgEks5uRzKrgaJpZM4VvMKk> .

[Dhaulagiri]

One thing I noticed is that it may be worth holding this until all the tests are converted. The way this is written, if a type of test hasn't been converted no test file will be generated since the blueprints won't exist.

[Dhaulagiri]

Actually, my comment above is not accurate. I was trying to generate a mixin test but that doesn't actually exist for even the previous version of mocha tests 🤷‍♂️ . I'll carry on doing these one at a time with the intention of getting them all done soon regardless.

[Turbo87]

@Dhaulagiri looks good in general, but keep in mind that ember-cli-mocha should eventually also support this new style.

[Dhaulagiri]

@Turbo87 that is good to know, I was under the impression that going forward one would simply use ember-mocha directly and not use ember-cil-mocha`. Would it be worth accounting for that right now as part of this effort or should we tackle that separately?

I'll try to get a separate discussion going at some point, but it seems like we could also deprecate and remove the pre 0.12 blueprints since it has been quite a long time since those were the default.

[Turbo87]

I was under the impression that going forward one would simply use ember-mocha directly and not use ember-cil-mocha

eventually that should be possible, but right now ember-cli-mocha contains the blueprints that automatically adjust the tests/test-helper.js to use Mocha instead of QUnit, and some older versions of e.g. ember-cli-eslint are not aware of ember-mocha being a viable option.

that said, the blueprints in ember-cli-mocha are not up-to-date with the changes in ember-mocha yet, which is precisely the reason why there is no current release yet.