[BUGFIX beta] computed.sort array should update if sort properties array is empty #16632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failure is related to a Browserstack issue. |
rwjblue
requested changes
May 16, 2018
| @@ -1297,6 +1297,29 @@ moduleFor( | |||
| ); | |||
| } | |||
|
|
|||
| ['@test array should update if sort properties array is empty'](assert) { | |||
There was a problem hiding this comment.
Can you update this title to be @test array should update if items to be sorted is replaced when sort properties array is empty, and then add a second test as @test array should update if items to be sorted is mutated when sort properties array is empty?
| 'array is not changed' | ||
| ); | ||
|
|
||
| set(o, 'items', emberA([5, 6, 7, 8, 9, 10, 11, 0, 1, 2, 3, 4])); |
There was a problem hiding this comment.
This test is testing "replacement" of items, not mutation.
Can you add another test that does o.get('items').pushObject(...)?
|
@rwjblue feedback was applied 👍 |
rwjblue
approved these changes
May 16, 2018
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, when the sort properties array is empty,
computed.sortwas returning the original array, but not responding to any changes in that array.The result was that any
computed.sortnever changed, even when the dependent array changed.I hope the (previously failing) test is self explanatory.
Is there a chance we can backport this to previous ember versions?
Please let me know if anything else is needed from me. Thanks!