Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX release] avoid strict assertion when object proxy calls thru for function #16560

Merged
merged 1 commit into from
Apr 22, 2018

Conversation

toranb
Copy link
Contributor

@toranb toranb commented Apr 21, 2018

Upgrading to ember v3.1 recently I bumped into this strict assertion around ObjectProxy which broke the consumers of that addon. More details (including a full example app) and discussion w/ Robert are included in the original issue I opened last week

#16521

@rwjblue
Copy link
Member

rwjblue commented Apr 21, 2018

We discussed this exact thing at the core team meeting yesterday, and came to the same conclusion, and we are 👍 on moving forward with this tweak to the proxy assertion system.

@toranb - Two small changes here and this is good to land (and can ultimately make its way to 3.1.x):

  1. Looks like the code-quality job failed, should be able to fix via yarn lint:fix.
  2. Can you prefix the commit (and PR title) with [BUGFIX release]?

@toranb toranb changed the title PROXY: avoid strict assertion when object proxy calls thru for function [BUGFIX release] avoid strict assertion when object proxy calls thru for function Apr 22, 2018
@toranb
Copy link
Contributor Author

toranb commented Apr 22, 2018

@rwjblue done and done my friend. Thanks for considering this patch for 3.1X :) I would greatly appreciate it!

@rwjblue rwjblue merged commit eca00fe into emberjs:master Apr 22, 2018
@rwjblue
Copy link
Member

rwjblue commented Apr 22, 2018

Thank you!

@rwjblue rwjblue added this to the v3.1.x milestone Apr 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants