Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix] Adds options checking ability to debug/deprecation test helpers #16520

Merged
merged 1 commit into from
Apr 14, 2018
Merged

[bugfix] Adds options checking ability to debug/deprecation test helpers #16520

merged 1 commit into from
Apr 14, 2018

Commits on Apr 14, 2018

  1. [bugfix] Adds options checking ability to debug/deprecation test helpers 

    With Ember v3 we now require that deprecations receive `id` and `until`
options. It's a hard error if they are not included, as happened
recently. This PR adds the ability to check for options when asserting
in debug helpers, so we can assert that all deprecations internally
receive these options. It also updates all outstanding cases where an
id/until value were not passed.
    @pzuraq
    pzuraq committed Apr 14, 2018
    Configuration menu
    Copy the full SHA
    4d13b71 View commit details
    Browse the repository at this point in the history