[bugfix] Adds options checking ability to debug/deprecation test helpers #16520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With Ember v3 we now require that deprecations receive `id` and `until` options. It's a hard error if they are not included, as happened recently. This PR adds the ability to check for options when asserting in debug helpers, so we can assert that all deprecations internally receive these options. It also updates all outstanding cases where an id/until value were not passed.
|
In general I matched the existing style of the MethodCallTracker class, but I'd be happy to refactor it to use modern class syntax and idioms. Wanted to make sure this was the correct direction before diving into that. |
|
Thank you very much for making sure the ember-dev assertion helpers flag this! |
rwjblue
approved these changes
Apr 14, 2018
|
Will need to cherry pick this into beta... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Ember v3 we now require that deprecations receive
idanduntiloptions. It's a hard error if they are not included, as happened
recently. This PR adds the ability to check for options when asserting
in debug helpers, so we can assert that all deprecations internally
receive these options. It also updates all outstanding cases where an
id/until value were not passed.