Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX beta] Fix various issues with descriptor trap. #16169

Merged
merged 4 commits into from
Jan 23, 2018
Merged

[BUGFIX beta] Fix various issues with descriptor trap. #16169

merged 4 commits into from
Jan 23, 2018

Commits on Jan 23, 2018

  1. [BUGFIX beta] Cache the descriptor trap. 

    Prior to this change, a new proxy was created for every property access.
This resulted in some pretty bizarre semantics. Consider the following:

```js
let Foo = Ember.Object.extend({
  bar: Ember.computed(function() { });
});

let obj = Foo.create();
console.log(obj.bar === obj.bar);
// => false
```

O_o
    @rwjblue
    rwjblue committed Jan 23, 2018
    Configuration menu
    Copy the full SHA
    21c5a77 View commit details
    Browse the repository at this point in the history

  2. [BUGFIX beta] Avoid adding enumerable properties to Array.prototype. 

    `Ember.NativeArray` is a normal Ember.Mixin that we mix into
`Array.prototype` when prototype extensions are enabled. Mutating a
native object prototype like this should _not_ result in enumerable
properties being added (or we have significant issues with things like
deep equality checks from test frameworks, or things like
`jQuery.extend(true, [], [])`).

this is a hack, and we should stop mutating the array prototype by
default 😫
    @rwjblue
    rwjblue committed Jan 23, 2018
    Configuration menu
    Copy the full SHA
    a6440b5 View commit details
    Browse the repository at this point in the history

  3. [BUGFIX beta] Do not add enumerable properties to Function.prototype.

    @rwjblue
    rwjblue committed Jan 23, 2018
    Configuration menu
    Copy the full SHA
    11ac59f View commit details
    Browse the repository at this point in the history

  4. [BUGFIX beta] Do not add enumerable properties to String.prototype.

    @rwjblue
    rwjblue committed Jan 23, 2018
    Configuration menu
    Copy the full SHA
    008a7a8 View commit details
    Browse the repository at this point in the history